Skip to content

module: enable import support for addons by default#64221

Open
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:enable-addon-modules
Open

module: enable import support for addons by default#64221
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:enable-addon-modules

Conversation

@legendecas

@legendecas legendecas commented Jun 30, 2026

Copy link
Copy Markdown
Member

Enable experimental import support for .node addons by default.

@legendecas
module: enable import support for addons by default
d2e390a 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Jun 30, 2026
@legendecas legendecas added the esm Issues and PRs related to the ECMAScript Modules implementation. label Jun 30, 2026
@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 1, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74467/

@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74487/

@geeksilva97 geeksilva97 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes
@geeksilva97 geeksilva97 geeksilva97 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. config Issues or PRs related to the config subsystem esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas @nodejs-github-bot @joyeecheung @geeksilva97 @marco-ippolito